Previously, these tests always errored:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/supybot/test.py", line 214, in runTest
originalRunTest()
File "/usr/local/lib/python3.7/dist-packages/supybot/test.py", line 214, in runTest
originalRunTest()
File "./NuWeather/test.py", line 73, in testSavedLocation
self.assertError('weather') # No location set
File "/usr/local/lib/python3.7/dist-packages/supybot/test.py", line 344, in assertError
m = self._feedMsg(query, expectException=True, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/supybot/test.py", line 298, in _feedMsg
to = self.irc.nick
AttributeError: 'NoneType' object has no attribute 'nick'
* Making the output for nowplaying immersive
Added a simple conditional to make the output of now playing a little more aesthetically pleasing.
mogad0n is listening to Roller Mobster by Carpenter Brut [Trilogy]
vs
mogad0n listened to Roller Mobster by Carpenter Brut [Trilogy] just now.
Close#92
This happens because the named reference to the "Gitlab" class is replaced by a new version on reload, making the old instance no longer an instance of it.
(cherry picked from commit f5ffcee53f)
This behaviour was unclear and misleading for a number of reasons:
- The channel name was actually only used for checking the bot's channel presence, and not as the announcement target.
- What the plugin actually did is check *all* channels the bot is in on the target network for configured announcements,
and announce to all of them (regardless of what channel was given in the URL).
Backwards compatibility with the old URL format is kept with this commit.
(cherry picked from commit 630786e541)
Instead of fixing the webhook handler to the network where the plugin was loaded, dynamically search through networks (much like the plugin already did with channels).
This also makes the plguin raise an explicit error if a network+channel target is unknown, instead of leaving any frontend servers with confusing 502 (Bad Gateway) errors.
(cherry picked from commit 140d724fb3)
This requires commit b54d8f8073, which separates the timeout and no match cases.
Also, raise the default processTimeout as the plugin now aborts on the first message that times out.
