PsychoticNinja/oddluck-limnoria-plugins
1
0
Fork 0
mirror of https://github.com/oddluck/limnoria-plugins.git synced 2025-04-25 20:41:21 -05:00
Code Issues Projects Releases Wiki Activity

SpiffyTitles: better error handling

Browse Source
This commit is contained in:
oddluck 2020-05-11 08:13:44 -04:00
parent e086f78679
commit 8fb4618d79
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
SpiffyTitles/plugin.py
View File

@ -228,11 +228,16 @@ class SpiffyTitles(callbacks.Plugin):
(html, is_redirect) = self.get_source_by_url(url, channel)
if html:
title = self.get_title_from_html(html)
if title:
title_template = default_template.render(
title=title, redirect=is_redirect
if not title:
log.error(
"SpiffyTitles: Unable to parse title from html response for %s"
% (url)
)
return title_template
title = self.registryValue("badLinkText", channel=channel)
title_template = default_template.render(
title=title, redirect=is_redirect
)
return title_template
else:
log.debug(
"SpiffyTitles: default handler fired but doing nothing because disabled"
@ -392,7 +397,10 @@ class SpiffyTitles(callbacks.Plugin):
title = None
soup = BeautifulSoup(html)
if soup:
title = soup.title.string.strip()
try:
title = soup.title.string.strip()
except:
pass
if title:
return title
else:
@ -468,7 +476,7 @@ class SpiffyTitles(callbacks.Plugin):
log.error(
"SpiffyTitles HTTP response code %s" % (request.status_code,)
)
text = self.registryValue("badLinkText")
text = self.registryValue("badLinkText", channel=channel)
text = (
"<html><head><title>{0}</title>"
"</head><body></body></html>".format(text)