jrd/irssi
1
0
Fork 0
forked from PsychoticNinja/irssi
Code Issues Pull Requests Projects Releases Wiki Activity

Silence a compiler warning.

Browse Source 
If the first g_module_symbol call failed, module_deinit was set
to value2, which is uninitialized.  Move the assignment after
checking variable found to silence the warning.
This commit is contained in:
David Hill 2014-06-15 15:40:08 -04:00
parent 57f138c087
commit 5b2d189ab5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/modules-load.c
View File

@ -184,9 +184,6 @@ static int module_load_name(const char *path, const char *rootmodule,
g_free(initfunc); g_free(initfunc);
g_free(deinitfunc); g_free(deinitfunc);
module_init = value1;
module_deinit = value2;
if (!found) { if (!found) {
module_error(MODULE_ERROR_INVALID, NULL, module_error(MODULE_ERROR_INVALID, NULL,
rootmodule, submodule); rootmodule, submodule);
@ -194,6 +191,9 @@ static int module_load_name(const char *path, const char *rootmodule,
return 0; return 0;
} }
module_init = value1;
module_deinit = value2;
/* Call the module's init() function - it should register itself /* Call the module's init() function - it should register itself
with module_register() function, abort if it doesn't. */ with module_register() function, abort if it doesn't. */
module_init(); module_init();