89 Commits

Author SHA1 Message Date
Ailin Nemui
9181796472 correct wrong function prefixes: g_istr -> i_istr 2021-01-07 10:09:45 +01:00
ailin-nemui
7e6e1f2e10 Use full paths to includes 2019-05-01 22:08:45 +02:00
dequis
9dd836b876 Fix "discards ‘const’ qualifier" warnings 2018-08-24 02:11:22 -03:00
coypu@sdf.org
610ab2dafa Use-after-frees
Hi folks!

I tried clang-static-analyzer on irssi 1.1.1, it seems like it
finds some things. Here's a diff, but there might be more that you would
want to check, or choose to work differently.

(in special-vars.c, ret is commands->data sometime)

I hope it's not too much trouble if reported as a confidential bug.
Thanks.
2018-08-23 14:13:48 +02:00
ailin-nemui
203f6c5329 also unblock theme elements when processing finished 2018-02-16 13:46:29 +01:00
ailin-nemui
e32e9d63c6 Do not read beyond end of escaped string
Credit to OSS-Fuzz
2018-02-08 14:11:23 +01:00
ailin-nemui
4c662acf95 another replaces fix
Credit to OSS-Fuzz
2018-02-01 14:19:40 +01:00
ailin-nemui
12360fb2c0 protect theme recursion 2018-02-01 10:21:31 +01:00
ailin-nemui
126189bb37 we probably should not try to replace replaces
Credit to OSS-Fuzz
2018-01-29 09:28:55 +01:00
ailin-nemui
00c80cb6fc fix out of bounds read in compress_colors
Reported by Hanno Böck.

Fixes GL#12
2017-10-07 20:48:53 +02:00
pisculichi
47e792da05 Fix some ANSI C issues. 2016-05-03 15:28:20 +00:00
Alexander Færøy
eb0f09073c Merge pull request #199 from ailin-nemui/config-parser
Make config parser more robust
2015-04-17 21:23:03 +02:00
dequis
f14199d9c1 Change all strcmp() to g_strcmp0() to handle nulls gracefully
Just a string replacement (but i did check every one of them)

    sed -i 's/strcmp(/g_strcmp0(/g' **/*.c
2015-04-07 22:41:05 -03:00
Ailin Nemui
96d4fb9156 add CONFIG_REC to config_node_section* APIs
this adds the CONFIG_REC * to the config_node_section and
config_node_section_index APIs as they will require access to the config
cache later on to make the config parser more robust.
2015-02-17 09:50:55 +01:00
Michael Vetter
51239925ec source cleanup: remove trailing whitespaces 2014-09-11 19:10:33 +02:00
Ailin Nemui
96a292d40e Finish 256 colour support for Irssi
256 colour patch is cleaned up and the remaining cases are made work,
this includes especially Theme support, which was not implemented
before. Changes not related to colours were reverted again, making a
review of the two patches against master easier to follow.

As a byproduct of the Hex-colour code parser, the 24bit colours are
also implemented. Actually using them in the terminal is guarded by a
compile time switch (as well as a run time switch), as it breaks the
existing colour protocol and requires additional storage.

To make a seamless usage, down-conversion is provided for 8 and 16
colours.

Diverging from Tom's approach, the colour protocol is reverted back to
the original one. Unfortunately, the changes required in the Theme
engine will break the API.

For more details, please refer to the patch documentation at either
http://irssi-docs.wikispaces.com/Notes-256-Colour or
https://github.com/shabble/irssi-docs/wiki/Notes-256-Colour
2014-06-30 02:41:34 +02:00
David Hill
9d6cd87b0f Replace deprecated g_basename with g_path_get_basename. 2014-06-22 20:39:35 -04:00
David Hill
0d4f13d20f Replace deprecated g_str[n]casecmp with g_ascii_str[n]cmp. 2014-06-10 12:06:19 -04:00
Emanuele Giaquinta
58d050db7c Fix minor leak.
git-svn-id: file:///var/www/svn.irssi.org/SVN/irssi/trunk@4847 dbcabf3a-b0e7-0310-adc4-f8d773084564
2008-05-23 11:19:43 +00:00
Emanuele Giaquinta
7df46597e1 Use g_ascii_str{,n}casecmp for case insensitive comparison with
ascii only strings.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4738 dbcabf3a-b0e7-0310-adc4-f8d773084564
2008-03-09 12:01:16 +00:00
Wouter Coekaerts
9c2d621cc6 Oops. Update address correctly now.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4490 dbcabf3a-b0e7-0310-adc4-f8d773084564
2007-05-08 18:41:10 +00:00
Wouter Coekaerts
023026e12b Update FSF address
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4489 dbcabf3a-b0e7-0310-adc4-f8d773084564
2007-05-08 18:16:58 +00:00
Wouter Coekaerts
d5c5883867 fix completion for /format (Bug 143)
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3991 dbcabf3a-b0e7-0310-adc4-f8d773084564
2005-09-10 13:19:20 +00:00
Timo Sirainen
43893ce50e typo: themes weren't defaulting their abstracts to internal theme
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3085 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-12-29 16:11:16 +00:00
Timo Sirainen
9c18cb00e7 Added support to define new default abstracts at runtime.
Irssi::abstracts_register([key => value, ...]);


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3079 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-12-28 15:25:10 +00:00
Timo Sirainen
d5bc95bc22 Make sure we aren't using a destroyed theme
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3073 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-12-23 08:36:25 +00:00
Timo Sirainen
e0c66e3122 Previous theme patch fixes by c0ffee
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3058 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-12-11 10:00:51 +00:00
Timo Sirainen
abd9e6f616 Better support %n in theme abstracts. Patch by c0ffee.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3043 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-12-04 20:51:51 +00:00
Timo Sirainen
3dda9ab2df statusbar is now also updated for connecting-servers.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2922 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-09-14 23:23:57 +00:00
Timo Sirainen
38ce412a5d /RELOADing broken theme file doesn't crash irssi anymore.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2880 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-08-22 20:49:07 +00:00
Timo Sirainen
ca234bdf5e *** empty log message ***
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2553 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-03-10 14:55:46 +00:00
Timo Sirainen
c62e430a92 /FORMAT tab completion went to infinite loop if there was more spaces than
one in the line..


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2530 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-02-25 17:48:08 +00:00
Timo Sirainen
dd65d300b0 Highascii chars in replaces block in theme files could have crashed irssi.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2524 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-02-22 12:56:24 +00:00
Timo Sirainen
490e411814 Don't crash if special vars line ends with '$'.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2488 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-02-17 09:37:23 +00:00
Timo Sirainen
a52d99ecf4 /RELOAD didn't update the statusbar colors the first time. /SET theme never
changed the statusbar colors.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2465 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-02-16 00:08:47 +00:00
Timo Sirainen
113ed9118e theme_format_compress_colors() doesn't assume the default color as %n
anymore. This is useful at least when you want to set statusbar background
color to %n so it won't be compressed to ""..


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2425 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-02-10 15:09:58 +00:00
Timo Sirainen
f4897860b5 toupper(), tolower(), isspace(), is..etc..() aren't safe with chars in some
systems, use our own is_...() functions now instead.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2348 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-01-27 20:45:59 +00:00
Timo Sirainen
9941ad52bf /SAVE -formats saves all the /formats to theme file.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2319 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-01-18 16:23:57 +00:00
Timo Sirainen
637a3c76c1 data_is_empty() might have crashed when it was called at the startup when
there was no active window.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2127 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-11-20 12:38:03 +00:00
Timo Sirainen
0c79d92d5d data_is_empty() didn't check properly for $0-$9 variables and broke
statusbar.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2086 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-11-19 16:38:00 +00:00
Timo Sirainen
fc91857029 Changed the escaping system - theme_format_expand_data()'s
EXPAND_FLAG_IGNORE_EMPTY now also checks if the argument is a $variable that
is empty. Statusbar now first expands the formats and after then expands
$variables. Should fix at least when trying to print #$$$ channel in
statusbar.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2023 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-11-15 20:02:15 +00:00
Timo Sirainen
2ba339a26b Added support for using terminfo/termcap instead of curses. By default,
configure chooses to use ncurses if found, of terminfo if only curses was
found. --with-terminfo parameter can be used to specify if you want it or
not.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1924 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-10-28 11:30:26 +00:00
Timo Sirainen
bc8ee2d26c Don't expand %{ and %} in themes to { and } - they could be treated as
abstracts again. Printing %{ and %} now prints just { and }. This fixes
printing {stuff} in statusbar (eg. {nick}).


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1885 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-10-21 17:56:42 +00:00
Timo Sirainen
29d983093e PARAMS -> ARGS fix again..
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1805 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-09-20 16:50:27 +00:00
Timo Sirainen
7814192f03 special vars: added PARSE_FLAG_ONLY_PARAMS. Theme loading now uses it so
you can use $C etc. in themes to print the active channel. printformat()
also expands it now correctly to the server/target where the message was
printed, not to the active window's server/target.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1802 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-09-20 15:58:14 +00:00
Timo Sirainen
f81291622f buffer overflow fix
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1647 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-07-25 19:16:21 +00:00
Timo Sirainen
79d1d7089a Added --home and --config command line parameters to irssi to specify
locations for ~/.irssi and ~/.irssi/config


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1626 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-07-15 00:39:48 +00:00
Timo Sirainen
2ddba459c0 Moved location of config, theme and doc files. Added debian dir for building a .deb easily.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1607 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-07-05 23:16:18 +00:00
Timo Sirainen
f20a6b0198 If .theme suffix was given for /SET theme, irssi printed "theme changed to
xxx" message every time any setting was changed.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1596 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-06-29 23:10:48 +00:00
Timo Sirainen
77b72271c8 when theme is changed, it should print the message to status window, not to active window..
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1585 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-06-28 17:43:53 +00:00