51 Commits

Author SHA1 Message Date
Will Storey
bbca1a5a0f Revert "Revert "Flag topic as unset if it is zero length""
This reverts commit 817179a7606b616795cf67e24505526dded34381.
2018-08-27 20:50:17 -07:00
ailin-nemui
817179a760
Revert "Flag topic as unset if it is zero length" 2018-08-13 14:43:25 +02:00
dequis
b114b11e36 channel_change_topic: change one strlen == 0 to *str == '\0' 2018-07-30 23:45:56 -03:00
Will Storey
15840ac27b If we receive a 0 length topic, record it as unset
Fixes #888.

Previously we showed that there was a topic set when using /topic, just
an empty one. This was different than how we show such topics when
initially joining a channel. Now we say that the topic is unset in both
cases.
2018-07-24 18:45:22 -07:00
Will Storey
0e187cf9cf Fix typo in comment 2018-07-24 18:29:31 -07:00
ailin-nemui
54d453623d do not record topic change time when sender is blank 2018-01-03 12:45:43 +01:00
LemonBoy
45dfe2ba38 Prevent a OOB read when parsing IRCNet ! channels
Make sure the string has enough data.
Fixes #16
2017-10-19 11:17:56 +02:00
dequis
f14199d9c1 Change all strcmp() to g_strcmp0() to handle nulls gracefully
Just a string replacement (but i did check every one of them)

    sed -i 's/strcmp(/g_strcmp0(/g' **/*.c
2015-04-07 22:41:05 -03:00
Michael Vetter
51239925ec source cleanup: remove trailing whitespaces 2014-09-11 19:10:33 +02:00
David Hill
0d4f13d20f Replace deprecated g_str[n]casecmp with g_ascii_str[n]cmp. 2014-06-10 12:06:19 -04:00
Emanuele Giaquinta
9fa8cbe7a2 Revert recode changes r4483 and r4715.
git-svn-id: file:///var/www/svn.irssi.org/SVN/irssi/trunk@4867 dbcabf3a-b0e7-0310-adc4-f8d773084564
2008-08-02 13:15:38 +00:00
Emanuele Giaquinta
d917a439da Cosmetic.
git-svn-id: file:///var/www/svn.irssi.org/SVN/irssi/trunk@4848 dbcabf3a-b0e7-0310-adc4-f8d773084564
2008-05-24 15:43:12 +00:00
Emanuele Giaquinta
0eb386ecd8 Move output recoding in irc_send_cmd_full.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4715 dbcabf3a-b0e7-0310-adc4-f8d773084564
2008-02-16 23:28:53 +00:00
Jilles Tjoelker
8312144547 Move the check for 4xx numeric for join failures last, so
that the CHANNEL_REC is still around when handlers for
specific numerics are executed. This allows removing the
ugly special case for 437; I will also use this for 470
(channel forwarding).


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4572 dbcabf3a-b0e7-0310-adc4-f8d773084564
2007-07-06 21:43:23 +00:00
Jilles Tjoelker
c0674522ae - Repair channels_rejoin_unavailable. Enabled by default,
this retries joins that failed because of netsplits
  (channel temporarily unavailable (437), duplicate channel)
  A few servers abuse 437 for juped channels which should
  not be retried, you should disable channels_rejoin_unavailable
  if this is a problem.
- Display 437 and 407 numerics if channels_rejoin_unavailable
  is not enabled.

Bug #495


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4537 dbcabf3a-b0e7-0310-adc4-f8d773084564
2007-06-03 13:08:47 +00:00
Wouter Coekaerts
9c2d621cc6 Oops. Update address correctly now.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4490 dbcabf3a-b0e7-0310-adc4-f8d773084564
2007-05-08 18:41:10 +00:00
Wouter Coekaerts
023026e12b Update FSF address
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4489 dbcabf3a-b0e7-0310-adc4-f8d773084564
2007-05-08 18:16:58 +00:00
Valentin Batz
19e800cf23 Fixed memory leaks when destroying a channel, when loading nonexisten scripts and in topics, patch by Toby Peterson
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3707 dbcabf3a-b0e7-0310-adc4-f8d773084564
2005-02-06 21:31:58 +00:00
Valentin Batz
7be7dd374c Added <tag>/<target> support for recode.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3692 dbcabf3a-b0e7-0310-adc4-f8d773084564
2004-12-20 13:59:15 +00:00
Timo Sirainen
226a567562 Recode patch by decadix/senneth
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3283 dbcabf3a-b0e7-0310-adc4-f8d773084564
2004-08-20 00:03:40 +00:00
Timo Sirainen
c8b792e92b Assume JOIN failed if we get any 4xx numeric back with channel name in it
before JOIN reply.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3152 dbcabf3a-b0e7-0310-adc4-f8d773084564
2003-11-16 18:44:36 +00:00
Timo Sirainen
0cdfa01971 Support 479 illegal channel name numeric
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3151 dbcabf3a-b0e7-0310-adc4-f8d773084564
2003-11-16 18:31:42 +00:00
Timo Sirainen
8070bb6704 If JOIN is sent to channel you've already joined, assume a missing PART and
resync the channel (instead of just ignoring as before). Patch by dg.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@3099 dbcabf3a-b0e7-0310-adc4-f8d773084564
2003-01-21 08:15:33 +00:00
Timo Sirainen
0b12cfe47b When checking for autojoin-on-invite channels, also check the short !channel
names.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2879 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-08-22 20:35:43 +00:00
Timo Sirainen
3303db4e87 Added support for 439 numeric ("Target change too fast") which may tell that
join was aborted.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2878 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-08-21 17:26:40 +00:00
Timo Sirainen
a6d6ade680 event_cannot_join() - changed check from NAMES got -> JOIN got, so the
channel isn't destroyed if join is received. dircproxy sent us 477 with
+channels before names list, and irssi aborted the join.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2827 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-05-26 17:50:55 +00:00
Timo Sirainen
e2ffdfec50 don't crash if server sends us !channel name less than 6 chars.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2817 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-05-19 08:18:09 +00:00
Timo Sirainen
3ecf864f18 !channel fixes.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2803 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-05-17 15:22:05 +00:00
Timo Sirainen
ede752530e new !channel support was buggy, as I tried it only with channel names having
less than 5 chars :) Now it works so that if you join !channel, you see it
as !channel. If you join !ABCDEchannel, you'll again see that.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2802 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-05-17 14:49:15 +00:00
Timo Sirainen
d346fbe1a9 Better !channel support - window items now have "visual_name" and channels
and queries also have "name". Normally they're identical but with !channels
the visible_name contains the short !channel name, while name contains
full !ABCDEchannel name.

The visible_name should be used whenever displaying the channel name, or as
printtext()'s target. So, this breaks a few scripts in !channels, they need
to be modified to use $channel->{visible_name} instead.

Also /LAYOUT SAVE should finally work properly with !channels.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2797 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-05-16 00:34:37 +00:00
Timo Sirainen
0cc7baa7df channel->topic_by now always contains the host info too (nick!user@host).
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2713 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-04-24 12:38:27 +00:00
Timo Sirainen
500ae5773e If autojoining to !channel failed because it didn't exist, create it by
joining to !!channel


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2627 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-03-17 02:50:12 +00:00
Timo Sirainen
7f8b0f07ec support for event 477 which aborts joins to +R channels in dalnet.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2414 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-02-10 12:13:00 +00:00
Timo Sirainen
4cd853feec Purge the commands in queue for channel if you get kicked from there.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2305 dbcabf3a-b0e7-0310-adc4-f8d773084564
2002-01-10 18:39:02 +00:00
Timo Sirainen
3f75bd3c3c Abort joins on 442-numeric that dalnet sends when you can't join to channel
because you've not registered your nick.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2288 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-12-31 16:30:32 +00:00
Timo Sirainen
8279d9c5c2 /SET join_auto_chans_on_invite setting wasn't registered so it didn't work..
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2115 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-11-20 02:04:44 +00:00
Timo Sirainen
cf0b863f39 /SET join_auto_chans_on_invite - patch by tygrys@moo.pl
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@2077 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-11-19 13:02:39 +00:00
Timo Sirainen
f354fe54c7 Moved some stuff from irc to core. Added command_bind_proto() function to
bind protocol-specific commands. Added #define command_bind_irc() for easier
access. CMD_IRC_SERVER(server) check should be done at the beginning of each
command requiring IRC server as active server, it handles it correctly the
cases when it is not. Did some other cleanups as well.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1955 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-11-02 01:05:14 +00:00
Timo Sirainen
072a4c774f If we receive INVITE for a channel that is added with /CHANNEL ADD -auto,
join it immediately.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1724 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-08-08 17:47:54 +00:00
Timo Sirainen
1f23c05ee7 CHANNEL_REC->get_join_data() - Returns the information needed to call
SERVER_REC->channels_join() for this channel. Usually just the channel name,
but may contain also the channel key.

If we receive PART-message to channel that hasn't received a JOIN yet,
don't destroy the channel. It's probably because we did quickly /PART +
/JOIN.

Moved /CYCLE to fe-common/core, it doesn't close the window for the cycled
channel anymore if you had autoclosing on.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1484 dbcabf3a-b0e7-0310-adc4-f8d773084564
2001-05-11 16:08:48 +00:00
Timo Sirainen
ae030c4302 Fix for handling duplicate channels
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@1018 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-12-22 13:02:33 +00:00
Timo Sirainen
9f2f1dc70a Server events: switched order of data and server parameters. it's now
SERVER_REC *server, const char *data, .. hope this doesn't cause too
many problems :)


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@967 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-12-05 21:12:52 +00:00
Timo Sirainen
2edcdd715f Remember who set the topic and when, display the info when using /TOPIC.
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@845 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-11-17 14:59:32 +00:00
Timo Sirainen
f6dbbfae1f When joining to !channel the join message was printed to active window
instead of the channel's.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@742 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-10-14 01:06:24 +00:00
Timo Sirainen
d398247f76 Handle event "407 duplicate channel" correctly - happens when trying to
create !channel (/join !!channel) while it already exists.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@741 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-10-14 01:03:11 +00:00
Timo Sirainen
e395e87ded Lots of moving stuff around - hopefully I didn't break too much :)
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@632 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-08-26 15:39:44 +00:00
Timo Sirainen
ef3cb01e6f Check that we're not already joined the channel when receiving JOIN
event, just to fix an irssi proxy bug..


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@565 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-07-31 22:10:18 +00:00
Timo Sirainen
afb6d6fd02 If join to !channel wasn't successfull (banned, etc.), Irssi didn't remove
the channel's window item.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@352 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-06-15 19:34:31 +00:00
Timo Sirainen
cbdaf7d06d Lots of changes again. Biggest ones:
- window's text buffer should work better
- themes are almost working, you can change the text formats with /format
- automatically try to rejoin the channel after 5 minutes if the join there
failed because it was "temporarily unavailable" (netsplits)
- generally cleaning code..


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@216 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-05-15 08:25:45 +00:00
Timo Sirainen
d3dc9a1307 .. lots of changes ..
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@197 dbcabf3a-b0e7-0310-adc4-f8d773084564
2000-05-04 10:32:42 +00:00